[SCHEDULE] Fix boundary check #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
were
approved these changes
Nov 18, 2018
|
Thanks for the contribution, please add a regression test-case https://docs.tvm.ai/contribute/code_review.html#ensure-test-coverage |
|
@tqchen sorry I was thinking that the fix is 2-line, and the correctness should be obvious. Okay I will send an update later today |
|
Just to make sure we don't stupidly change it back again, regression tests are also very useful during code refactors, since we might mistakenly reintroduce the bug again |
|
@tqchen added a unittest just now, CI passes, could you help review again? Thanks! |
tqchen
approved these changes
Nov 18, 2018
tqchen
added
status: accepted
and removed
status: need update
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
* Fix boundary check * Add unittest
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
* Fix boundary check * Add unittest
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
* Fix boundary check * Add unittest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #2088.
Details about this bug are discussed in this comment.
Related issues: #1014, #2088. Related PR: #1091 (which is approximately correct when
iv->dom->min == 0).CC: @tqchen @were.