[Bugfix] Recover original layout when alter_layout function return None #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthesun
reviewed
Nov 14, 2018
|
|
||
| g = g.apply("AlterOpLayout") | ||
|
|
||
| # pool1 get replaced - output layout of pool1 is not recorded |
There was a problem hiding this comment.
I think it would be helpful to have a tutorial briefly introducing layout related passes in tvm, making it easier for people to understand and debug. This pr itself lgtm.
kevinthesun
approved these changes
Nov 14, 2018
|
Thanks, @kevinthesun @yzhliu , this is now merged |
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
Closed
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the fix,
test_alter_func_return_none()would fail, produce the same result astest_consecutive_alter_layout(). Please help to review @merrymercy @kevinthesun