Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELAY][PASS] CombineParallelConv2D #2089
[RELAY][PASS] CombineParallelConv2D #2089
Changes from all commits
ca7a659
c1b73c1
febef4e
aaade9b
0318eef
002b4e5
f923a16
1934fd2
c638625
8186479
74ca32d
9ee9396
9aafe00
4302789
bed2900
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you give an example of values of
ndim
andarg_ndim
? When canchannel_pos
andarg_channel_pos
be different?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ndim is the dimension of output of con2
d, typically 4 if the layout is NCHW; arg_ndim is the dimension of argument, which doesn’t have to have the batch dimension, for example the per-channel bias have the shape [channels, 1, 1], and arg_ndim is 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, then for NCHW layout
arg_channel_pos
is 0, and for NHWC, the bias shape should be [1, 1, channels], soarg_channel_pos
is 2 ( 3 - 4 + 3). The math seems to check out.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes in this case.
channel_pos - ndim + arg_ndim
can be seen asarg_ndim - (ndim - channel_pos)
, which means start marching each dimension from the right (as per the broadcast semantic)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When branches[0][i] is a node where multiple branches meet,
parent_index
can be > 0. This is the only case whenparent_index
can be > 0. Correct?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another case is that the parent is on rhs of binary op