[Frontend][MXNet] Change mxnet graph traversal from recursion to iteration #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhreshold
suggested changes
Oct 27, 2018
nnvm/python/nnvm/frontend/mxnet.py
Outdated
| else: | ||
| node = _sym.Variable(name=name, **attr) | ||
| graph[name] = node | ||
| return [get_node(sym) for sym in symbol] |
There was a problem hiding this comment.
list is not a valid symbol, it's actually a GroupSymbol? Also here should assert if node is not None
|
Thanks @icemelon9 , @zhreshold can you take another look? |
zhreshold
approved these changes
Oct 29, 2018
|
@icemelon9 Thanks, LGTM now. |
|
Thanks @icemelon9 @zhreshold ! this is now merged |
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous _from_mxnet_impl uses recursion to traverse graph. It causes call stack overflow when there're too many symbols in the graph. Now create symbols using topological order.