[Frontend][Darknet] L2 normalization support in darknet #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siju-samuel @yzhliu Welcome for review. |
yzhliu
reviewed
Oct 23, 2018
| """Process the l2 normalization operation.""" | ||
| op_name, new_attrs = 'l2_normalize', {} | ||
| new_attrs['eps'] = attrs.get('eps', 0) | ||
| new_attrs['axis'] = attrs.get('axis', 1) |
There was a problem hiding this comment.
I don't really know darknet, would appreciate if you could point out where these two attrs come from. The overall functionality looks good to me.
There was a problem hiding this comment.
Sure. The darknet computes the l2 normalization always along the channel axis. So it doesn't store the axis information anywhere. And while dividing by sum it doesn't check if sum is greater than eps or not.
So i have made default eps as 0 and axis as 1 to make it compatible with TVM's L2 normalization implementation. You can have look at darknet's l2 normalization implementation here
yzhliu
approved these changes
Oct 24, 2018
eqy
pushed a commit
to eqy/tvm
that referenced
this pull request
Oct 29, 2018
* l2 normalization * retrigger CI
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
* l2 normalization * retrigger CI
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
* l2 normalization * retrigger CI
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
* l2 normalization * retrigger CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.