[Relay][Op]BroadcastToLike CollapseSumLike #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const Attrs& attrs, | ||
| const TypeReporter& reporter) { | ||
| CHECK_EQ(types.size(), 3); | ||
| reporter->Assign(types[2], types[1]); |
There was a problem hiding this comment.
Maybe see ReduceShapeImpl in https://github.com/dmlc/tvm/blob/master/nnvm/src/top/tensor/reduce.cc for guidance on how the axis params are supposed to work? (Strangely, collapse_sum itself doesn't use the reduction.)
There was a problem hiding this comment.
I am confused as well - I originally thought I need reduce_shape (which was at another pr), so at the mean time I can get this up.
MarisaKirisame
force-pushed
the
broadcast_collapse_like
branch
from
60e6984 to
83a6ce3
Compare
|
@tqchen can you give some review? |
|
please rebase against master after #1934 to make use of the newly introduced API and add test-case to make sure text format works. |
MarisaKirisame
force-pushed
the
broadcast_collapse_like
branch
from
3f75f4f to
a97b762
Compare
|
@tqchen I had rebased. |
|
The changes in the submodule seems to be unintentional and should not be included in this PR |
MarisaKirisame
force-pushed
the
broadcast_collapse_like
branch
from
a97b762 to
72f6f13
Compare
tqchen
approved these changes
Oct 21, 2018
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.