[Relay] GetItem #1861
Merged
[Relay] GetItem #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@junrushao1994 @srkreddy1238 @masahi please review. |
tqchen
requested changes
Oct 9, 2018
include/tvm/relay/expr.h
Outdated
| /*! \brief The tuple */ | ||
| Expr tuple; | ||
| /*! \brief which value to get */ | ||
| size_t field; |
There was a problem hiding this comment.
the main reason is that usually if we want to serialize the model, the type should have fixed size across platform(int32, or int64). index is a more commonly used term
include/tvm/relay/expr.h
Outdated
| @@ -378,6 +376,23 @@ class IfNode : public ExprNode { | |||
|
|
|||
| RELAY_DEFINE_NODE_REF(If, IfNode, Expr); | |||
|
|
|||
| /*! \brief Get a field out of a tuple. */ | |||
| class GetItem; | |||
tqchen
approved these changes
Oct 10, 2018
|
@junrushao1994 thx for reviewing! |
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetItem is a relay construct for getting field out of a tuple