[RELAY][OPS]LRN and L2_Normalize #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siju-samuel
force-pushed
the
relay_lrn_l2normalize
branch
from
e5255fb to
9c814b2
Compare
|
@tqchen @srkreddy1238 @junrushao1994 @MarisaKirisame please review. |
python/tvm/relay/op/nn/nn.py
Outdated
| The size of the local region to be considered for normalization. | ||
|
|
||
| axis : int, optional | ||
| input data layout channel axis. default value is 1 for NCHW format |
include/tvm/relay/attrs/nn.h
Outdated
| TVM_ATTR_FIELD(size).set_default(5) | ||
| .describe("The size of the local region to be considered for normalization."); | ||
| TVM_ATTR_FIELD(axis).set_default(1) | ||
| .describe("Input data layout channel axis"); |
There was a problem hiding this comment.
Axis of input data layout channel?
siju-samuel
force-pushed
the
relay_lrn_l2normalize
branch
from
9c814b2 to
4a17f63
Compare
siju-samuel
force-pushed
the
relay_lrn_l2normalize
branch
from
e1e978d to
054496a
Compare
junrushao
approved these changes
Oct 9, 2018
| @@ -383,3 +383,66 @@ def relu(data): | |||
| The computed result. | |||
| """ | |||
| return _make.relu(data) | |||
|
|
|||
|
|
|||
| def lrn(data, size=5, axis=1, bias=2, alpha=.00001, beta=0.75): | |||
There was a problem hiding this comment.
idk if it is good or not to use these defaults, but seems only AlexNet-like archs apply lrn somewhere, so it is fine.
|
l2 normalization is not as common and let us move it to level2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1799
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.