Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELAY][OP] comparison #1824

Merged
merged 5 commits into from
Oct 5, 2018
Merged

[RELAY][OP] comparison #1824

merged 5 commits into from
Oct 5, 2018

Conversation

junrushao
Copy link
Member

@junrushao junrushao commented Oct 5, 2018 •
edited
Loading

This PR contains the following operators by copy-pasting.

  • equal (only add docstring)
  • not_equal
  • greater
  • greater_equal
  • less
  • less_equal

TODO:

  • Check support level
  • Add tests
  • Find a right filename putting these operators. Is elemwise.cc the right place?

Related issue: #1799

@junrushao junrushao changed the title Add logical operators [RELAY][OP] Add logical operators Oct 5, 2018
@junrushao
Copy link
Member Author

@tqchen Can I assume support levels for these 6 operators are all 4?

@srkreddy1238
Copy link
Contributor

  • Find a right filename putting these operators. Is elemwise.cc the right place?

All these support broadcast versions, hence could go to broadcast.cc

@junrushao junrushao changed the title [RELAY][OP] Add logical operators [RELAY][OP] Add comparison operators Oct 5, 2018
@junrushao junrushao mentioned this pull request Oct 5, 2018
Closed
66 tasks
@junrushao
Copy link
Member Author

Testcases are added just now. 2 issues:

  1. Could we somehow add bool as an alias to uint1?
  2. Unknown type error is not handled properly [Relay][Bug] Error raised by relay.TensorType is not handled properly #1830

@junrushao
Copy link
Member Author

Rebased w.r.t the current master.

@junrushao
Copy link
Member Author

@tqchen @srkreddy1238 Hey folks, could you help review this PR?

@junrushao junrushao changed the title [RELAY][OP] Add comparison operators [RELAY][OP] comparison Oct 5, 2018
@tqchen tqchen merged commit d6ff734 into apache:master Oct 5, 2018
FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Dec 27, 2018
@junrushao @tqchen
[RELAY][OP] comparison (apache#1824)
17d7284
@junrushao junrushao deleted the relay-op-2 branch January 6, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junrushao @srkreddy1238 @tqchen