[Relay] More type alpha equality test coverage #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slyubomirsky
commented
Oct 5, 2018
| t2 = relay.TensorType((1, 2, 3), "float32") | ||
| t3 = relay.TensorType((1, 2, 3, 4), "float32") | ||
|
|
||
| tr1 = relay.TypeRelation(None, tvm.convert([t1, t2]), 1, None) |
There was a problem hiding this comment.
I would really appreciate pointers on how to specify a type relation function or attributes node from within Python (can't find any examples), if possible
There was a problem hiding this comment.
There was a problem hiding this comment.
Excellent, thank you. I will make the relation examples less trivial then.
slyubomirsky
force-pushed
the
alpha-eq-tests
branch
from
415e047 to
e39e3d9
Compare
slyubomirsky
changed the title
|
Given the operator push, I'll leave expr alpha equality tests for another PR |
tqchen
approved these changes
Oct 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alpha equality is deeply relied on by much of Relay, yet we have very little test coverage for it (mostly lost across different rewrites). I am going to add tests for more cases and in the process try to fix any missing functionality in alpha_eq itself. Please review my tests, as well as changes to alpha_eq, or suggest ways to improve or better organize the tests.
Still to do: