[Web] Allow deprecated API requestAdapterInfo with any cast #17420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlieFRuan
added a commit
to mlc-ai/web-llm
that referenced
this pull request
Sep 26, 2024
This PR bumps TVMjs (i.e. `@mlc-ai/web-runtime`) from `0.18.0-dev0` to `0.18.0-dev1`. The only change is: - apache/tvm#17420 TVMjs `0.18.0-dev1` is compiled at apache/tvm@5e85443 with apache/tvm#17420 cherry-picked on top This should fix: - #572
CharlieFRuan
added a commit
to mlc-ai/web-llm
that referenced
this pull request
Sep 26, 2024
### Change - #580 - Bumps TVMjs version to fix #572 ### TVMjs Updated TVMjs to `0.18.0-dev1`, compiled at apache/tvm@5e85443 with apache/tvm#17420 cherry-picked on top - The only diff is apache/tvm#17420
CharlieFRuan
added a commit
to mlc-ai/web-llm
that referenced
this pull request
Sep 27, 2024
### Change - This version tries to solve the same issue in `0.2.70`, which bumped TVMjs from `0.18.0-dev0` to `0.18.0.dev1` - This version bumps from `0.18.0.dev1` to `0.18.0.dev2` - The previous issue described in #581 was not resolved as apache/tvm#17420 missed an `await`. `0.18.0.dev2` resolves this. Confirmed in an older version of Brave browser: `Version 1.65.133 Chromium: 124.0.6367.208 (Official Build) (arm64)` ### TVMjs - Updated TVMjs to `0.18.0-dev2`, compiled at apache/tvm@5e85443 with apache/tvm#17420 cherry-picked on top - The only diff is apache/tvm#17420
|
@tvm-bot rerun |
tqchen
approved these changes
Sep 28, 2024
|
Hi @CharlieFRuan , recently release starts, but I found WebGPU part has some modification about version number. Is it required to change version in Each modification includes fixed five file modifications: #17156. If there are any modifications related to |
|
Hi @ysh329, thanks for the note! Just to check my understanding, does the version in |
|
@CharlieFRuan I think it's better keep same between |
|
@ysh329 I see, then I think it's easier for me to revert the version in |
|
@CharlieFRuan Don't worry. Let me fix this minor problem. |
|
Thanks a lot! |
This was referenced Oct 11, 2024
jzhao62
pushed a commit
to jzhao62/web-llm
that referenced
this pull request
Dec 8, 2024
…ai#580) This PR bumps TVMjs (i.e. `@mlc-ai/web-runtime`) from `0.18.0-dev0` to `0.18.0-dev1`. The only change is: - apache/tvm#17420 TVMjs `0.18.0-dev1` is compiled at apache/tvm@5e85443 with apache/tvm#17420 cherry-picked on top This should fix: - mlc-ai#572
jzhao62
pushed a commit
to jzhao62/web-llm
that referenced
this pull request
Dec 8, 2024
### Change - mlc-ai#580 - Bumps TVMjs version to fix mlc-ai#572 ### TVMjs Updated TVMjs to `0.18.0-dev1`, compiled at apache/tvm@5e85443 with apache/tvm#17420 cherry-picked on top - The only diff is apache/tvm#17420
jzhao62
pushed a commit
to jzhao62/web-llm
that referenced
this pull request
Dec 8, 2024
### Change - This version tries to solve the same issue in `0.2.70`, which bumped TVMjs from `0.18.0-dev0` to `0.18.0.dev1` - This version bumps from `0.18.0.dev1` to `0.18.0.dev2` - The previous issue described in mlc-ai#581 was not resolved as apache/tvm#17420 missed an `await`. `0.18.0.dev2` resolves this. Confirmed in an older version of Brave browser: `Version 1.65.133 Chromium: 124.0.6367.208 (Official Build) (arm64)` ### TVMjs - Updated TVMjs to `0.18.0-dev2`, compiled at apache/tvm@5e85443 with apache/tvm#17420 cherry-picked on top - The only diff is apache/tvm#17420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebGPU API
requestAdapterInfo()was deprecated as described here: https://developer.mozilla.org/en-US/docs/Web/API/GPUAdapter/requestAdapterInfo#browser_compatibility. This causednpm run buildunderweb/to cause error since it cannot findrequestAdapterInfo, hence the PR: #17371However, downstream users may still have older browser version and would still rely on
requestAdapterInfo(), see mlc-ai/web-llm#572 for an example.This PR casts
adaptertoanytype when callingrequestAdapterInfo(), so it does not complain about not being able to findrequestAdapterInfo()during compile time, hence no issue should be observed during runtime on older browsers, achieving backward compatibility.Bump TVMjs version from
0.18.0-dev0to0.18.0-dev2(skipped dev1 due to a mistake)