Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relax][PyTorch] Add support for torch.nn.functional.conv* #17325

Merged
merged 9 commits into from
Sep 3, 2024
Merged

[Relax][PyTorch] Add support for torch.nn.functional.conv* #17325

merged 9 commits into from
Sep 3, 2024

Conversation

mshr-h
Copy link
Contributor

@mshr-h mshr-h commented Aug 31, 2024 •
edited
Loading

Added the following supports

  • torch.nn.functional.conv1d
  • torch.nn.functional.conv_transpose1d
  • torch.nn.functional.conv_transpose2d
  • torch.nn.functional.conv3d

cc @vinx13 @yongwww @Hzfengsy @tqchen

@mshr-h mshr-h marked this pull request as draft August 31, 2024 17:39
@mshr-h mshr-h marked this pull request as ready for review August 31, 2024 18:16
@mshr-h mshr-h force-pushed the support-func-conv1d branch from 8d9cb16 to ba14bd1 Compare September 1, 2024 08:14
@mshr-h mshr-h marked this pull request as draft September 1, 2024 08:25
@mshr-h mshr-h changed the title [Relax][PyTorch] Add support for torch.nn.functional.conv1d [Relax][PyTorch] Add support for torch.nn.functional.conv* Sep 1, 2024
@mshr-h mshr-h marked this pull request as ready for review September 1, 2024 13:36
@tqchen
Copy link
Member

tqchen commented Sep 3, 2024

cc @yongwww do you mind take a look?

yongwww
yongwww approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@yongwww yongwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! Thanks for adding the support!

@tqchen tqchen merged commit 0e9c683 into apache:main Sep 3, 2024
23 of 24 checks passed
@mshr-h mshr-h deleted the support-func-conv1d branch September 5, 2024 02:12
@ysh329 ysh329 mentioned this pull request Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongwww yongwww yongwww approved these changes

@vinx13 vinx13 Awaiting requested review from vinx13

@Hzfengsy Hzfengsy Awaiting requested review from Hzfengsy

@tqchen tqchen Awaiting requested review from tqchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshr-h @tqchen @yongwww