[TIR] Extend DP4A tensor intrin #16293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vincentccc
commented
Dec 29, 2023
vincentccc
commented
- Update u8s8s32 s8u8s32 u8u8u32
vinx13
reviewed
Jan 2, 2024
Comment on lines
+46
to
+58
| #if !defined(__CUDACC_RTC__) && defined(__CUDA_ARCH__) | ||
| __SM_61_INTRINSICS_DECL__ int __dp4a(unsigned int srcA, int srcB, int c) { | ||
| int ret; | ||
| asm volatile ("dp4a.u32.s32 %0, %1, %2, %3;" : "=r"(ret) : "r"(srcA), "r"(srcB), "r"(c)); | ||
| return ret; | ||
| } | ||
|
|
||
| __SM_61_INTRINSICS_DECL__ int __dp4a(int srcA, unsigned int srcB, int c) { | ||
| int ret; | ||
| asm volatile ("dp4a.s32.u32 %0, %1, %2, %3;" : "=r"(ret) : "r"(srcA), "r"(srcB), "r"(c)); | ||
| return ret; | ||
| } | ||
| #endif /* !__CUDACC_RTC__ && defined(__CUDA_ARCH__) */ |
There was a problem hiding this comment.
these definitions are similar to sm_61_intrinsics.hpp, is there a reason to include them here?
There was a problem hiding this comment.
This is because the sm_61_intrinsics.hpp exclude s8xu8 and u8xs8 case
vinx13
approved these changes
Jan 5, 2024
vincentccc
force-pushed
the
dp4a_intrin
branch
from
345e70b to
69f056f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.