Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unity][lm_support] window kvcache sink #16240

Merged
merged 2 commits into from
Dec 15, 2023
Merged

[Unity][lm_support] window kvcache sink #16240

merged 2 commits into from
Dec 15, 2023

Conversation

davidpissarra
Copy link
Contributor

Three-line change to adapt WindowOverride to support sinks. Also added a correctness test.

cc @tqchen

@github-actions github-actions bot requested a review from tqchen December 14, 2023 13:35
@tqchen tqchen merged commit cd9445d into apache:unity Dec 15, 2023
15 checks passed
@davidpissarra davidpissarra mentioned this pull request Dec 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidpissarra @tqchen