[Bugfix] Fix Disco-CUDAGraph Integration #15870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @jinhongyii |
Hzfengsy
approved these changes
Oct 4, 2023
jinhongyii
reviewed
Oct 4, 2023
| void Clear() { NCCL_CALL(ncclCommDestroy(comm)); } | ||
| void Clear() { | ||
| NCCL_CALL(ncclCommDestroy(comm)); | ||
| if (default_stream != nullptr) { |
There was a problem hiding this comment.
IIUC, default_stream is always nullptr
There was a problem hiding this comment.
given in this case default_stream is a member that can be changed later, i think having such code is better. Note it is not the same as the default stream in the CUDA terminology, but in the nccl runtime
jinhongyii
reviewed
Oct 4, 2023
|
|
||
| deviceStream_t GetDefaultStream() { return nullptr; } | ||
| deviceStream_t GetDefaultStream() { | ||
| const auto* func = tvm::runtime::Registry::Get("runtime.get_" TVM_DISCO_DEVICE_NAME "_stream"); |
There was a problem hiding this comment.
I don't see any stream initialization in this file , so I'm confused what this function returns
There was a problem hiding this comment.
it's initialized in cudagraph
This PR fixed a bug introduced in apache#15827 since which the cudagraph's stream is discarded.
junrushao
force-pushed
the
bugfix/2023-10-03/fix-cudagraph-integration
branch
from
88536e1 to
e79e582
Compare
jinhongyii
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed a bug introduced in #15827 since which the cudagraph's stream is discarded.