[TOPI] add injective scheduler for HLS backends #1553
Conversation
|
@tmoreau89 @comaniac @nishi-t Can you please review this PR? |
|
Not very familiar with the TOPI, but the code generation part looks good to me. |
|
Due to recent history change to master, we will need everyone to rebase against the current master, see #1394 we are sorry for the inconvenience |
kazum
force-pushed
the
hls-injective-scheduler
branch
from
ad71d27 to
dc6c2f5
Compare
|
Rebased. |
src/codegen/codegen_vhls.cc
Outdated
| PrintExpr(op->a, os); | ||
| os << ", "; | ||
| PrintExpr(op->b, os); | ||
| os << ')'; |
There was a problem hiding this comment.
Could you introduce PrintBinaryExpr to avoid boilerplate code for binary expression?
c.f. https://github.com/dmlc/tvm/blob/master/src/codegen/codegen_c.cc#L372
|
@nishi-t Done, thanks! |
|
@kazum Looks good to me. thanks |
yzhliu
added
topi
|
Catching up on this PR. This seems sound to me, unifying code gen between HLS languages is the right approach. |
|
I approved the PR. @kazum could you rebase against master so we can merge it back? Thanks! |
kazum
force-pushed
the
hls-injective-scheduler
branch
from
44007db to
cb74804
Compare
|
@tmoreau89 Rebased, thanks. :) |
tqchen
added
status: accepted
and removed
status: need update
This PR adds initial support for schedulers of HLS backends (e.g. SDAccel, AOCL). Optimization for performance and resource usage is a future work.
To pass tests, this PR also adds support for max, min, and some math operations to the SDAccel backend.