-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend][ONNX] add onnx Mish operator #15415
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Please add a testcase for it |
Hey @Hzfengsy, I thought tests for the onnx frontend are directly picked from their test suite. There is one for test_mish as well, which executes through the parametrised function, test_onnx_nodes, should i write a separate one ? |
Please add a standalone test in the file https://github.com/apache/tvm/blob/main/tests/python/frontend/onnx/test_forward.py |
Hey @Hzfengsy, just added a test |
Hey @Hzfengsy, can this be merged now ? |
Thanks @Aarsh2001 |
Mish - tests pass locally for
llvm
target on acpu