-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FRONTEND][MXNET] Fix L2normalization error when run ssd model #1527
Conversation
* Fix a link in android_deploy/README.md and a error while building android_deploy. * revert and change APP_STL in Application.mk
* add support for subgraphs. * fix. * fix. * Fix compilation error * Fix compilation error * add comments. * update comments. * Sanity check on subgraphs when creating IndexedGraph * avoid the overhead of sanity check. * Stop using non-recursive DFS * Trigger CI * trigger CI
@kaishijeng Yes. L2Normlization is required for gluoncv ssd implementation: https://github.com/dmlc/gluon-cv/blob/master/gluoncv/model_zoo/ssd/ssd.py I plan to support deploying these models in the next few weeks. |
Do you plan to support OpenCL for mobilenet ssd? Thanks, |
Please rebase according to #1394 |
@kaishijeng I think @Laurawly is working for OpenCL SSD support. |
@yzhliu i updated l2_normalize's implementation with test cases. Plz help me review it. Thanks! |
@titikid need to rebase according to #1394 . currently the PR has too many unrelated stuffs to review. Sorry for the inconvenience. |
@yzhliu sorry. I got some issues when rebasing. May i make another PR? |
Any progress of gluoncv ssd implementation: ? Thanks, |
gluoncv ssd will be supported through hybrid frontend. It is delayed due to some limitation of hybrid frontend. |
@kevinthesun Anything that we can help with? |
Any progress on this? Thanks, |
@titikid @kevinthesun Does current TVM code support mobilenet-ssd yet? Thanks, |
Have you tried mxnet_ssd model? I think that should be supported now. Gluoncv models are in progress. |
Does it have mobilenet_ssd? |
https://github.com/zhreshold/mxnet-ssd contains mobilenet ssd. |
I am not able to run deploy_ssd.py successfully. So I don't think I can try mobilenet_ssd using deploy_ssd.py Thanks, |
You can file a issue on discuss forum. |
This PR fix error L2Normalization when run ssd models from MXNET frontend. I also faced another error when run it with target openCL as described here https://github.com/dmlc/tvm/issues/1302. For short term solution, i reduced num_thread_x = 8 (line 307) and ofactor = 4 (line 309) in topi/python/topi/cuda/conv2d_nchw.py and i could run my ssd model successfully. How about long term solution for this issue?