Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[microNPU] Add support for ResizeNearestNeighbor with half_pixel_centers=True #14401

Merged
merged 3 commits into from
Apr 5, 2023
Merged

[microNPU] Add support for ResizeNearestNeighbor with half_pixel_centers=True #14401

merged 3 commits into from
Apr 5, 2023

Conversation

ilyag-grovety
Copy link
Contributor

This PR involves supporting the legalization case of RESIZE_NEAREST_NEIGHBOR where coordinate transformation mode is set to half_pixel.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 24, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@ilyag-grovety
Copy link
Contributor Author

ilyag-grovety commented Mar 27, 2023 •
edited
Loading

@tvm-bot rerun

lhutton1
lhutton1 reviewed Mar 28, 2023
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ilyag-grovety, I just had a couple of comments

python/tvm/relay/op/contrib/ethosu.py Outdated Show resolved Hide resolved
tests/python/contrib/test_ethosu/test_codegen.py Outdated Show resolved Hide resolved
lhutton1
lhutton1 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ilyag-grovety!

@lhutton1 lhutton1 merged commit 9dcd40d into apache:main Apr 5, 2023
@lhutton1
Copy link
Contributor

lhutton1 commented Apr 5, 2023

Thanks @ilyag-grovety!

@ysh329 ysh329 mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhutton1 lhutton1 lhutton1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilyag-grovety @tvm-bot @lhutton1