[NNVM][TENSORFLOW] bug fix on bilinear and resize op integration in frontend. #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srkreddy1238
force-pushed
the
master
branch
5 times, most recently
from
65009f3 to
924925e
Compare
…ation to frontend. * strengthen the testcases with random data.
|
what was the bug? |
|
align_corners check was flipped. |
|
do you have a test cast that fails without this PR? |
|
@masahi I found the flag flip issue while checking with tensorflow result (which is a new testcase now with front end integration). earlier the comparison was with python implementation which also had the flag flip. The new tensorflow test case should be good enough now |
masahi
reviewed
Jul 18, 2018
| from PIL import Image | ||
| img_array = np.random.uniform(size=(1, 600, 600, 3)).astype("uint8") | ||
| img = Image.frombuffer('RGB', (600, 600), img_array.tostring(), 'raw', 'RGB', 0, 1) | ||
| img.save('tf_test.jpg'); |
There was a problem hiding this comment.
not sure why you need to save an image, but shouldn't this be deleted after test is done?
Or it may be better to use temporary file here.
There was a problem hiding this comment.
@masahi used temp for image. Please review now.
masahi
approved these changes
Jul 18, 2018
|
Thanks @srkreddy1238 @masahi , this is merged |
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Aug 4, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.