Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIR] Remove LoadNode and StoreNode #14381

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Mar 23, 2023

Load and Store were deprecated in RFC0039. It has been several releases since the deprecation and it's no longer used in the codebase, now it is time to remove them.

cc @tqchen @Lunderberg @junrushao

@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 23, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This has been dead code for a long time

Copy link
Contributor

@Lunderberg Lunderberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clean-up!

Copy link
Contributor

@MasterJH5574 MasterJH5574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vinx13!

@MasterJH5574 MasterJH5574 merged commit b987556 into apache:main Mar 24, 2023
@masahi
Copy link
Member

masahi commented Apr 1, 2023

@tqchen Seems the latest rebase broke build, since Load/StoreNode are used by relax code

@tqchen
Copy link
Member

tqchen commented Apr 1, 2023

thanks @masahi for the catching, working to fix it atm, will report back

@tqchen
Copy link
Member

tqchen commented Apr 1, 2023

should be fixed by now, sorry for the trouble (you need to do another rebase cherry pick your change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants