Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][ETHOSN] Add ssh to the driver stack installation #14246

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

lhutton1
Copy link
Contributor

@lhutton1 lhutton1 commented Mar 9, 2023

Some use cases of the NPU integration rely on ssh being available within the docker image in order to launch an RPC server on a remote device. This commit adds ssh as a dependency on the NPU driver stack installation.

cc @ashutosh-arm @Liam-Sturge

Some use cases of the NPU integration rely on ssh being avilable
within the docker image in order to launch an RPC server on a remote
device. This commit adds ssh as a dependency on the NPU driver stack
installation.

Change-Id: I6830a1536789ebbab161080010c94e7a097e36ce
@github-actions github-actions bot requested a review from ashutosh-arm March 9, 2023 14:34
@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 9, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@lhutton1 lhutton1 changed the title [ETHOSN] Add ssh to the driver stack installation [CI][ETHOSN] Add ssh to the driver stack installation Mar 10, 2023
@lhutton1
Copy link
Contributor Author

lhutton1 commented Mar 10, 2023

There is an argument that this would be useful for development within the containers more generally (thanks @Liam-Sturge @ashutosh-arm for raising this!). Wondering if the "[CI]" folks had any thoughts? Could this be something we add to ubuntu_install_core.sh instead?

@ashutosh-arm
Copy link
Contributor

@driazati to confirm if its okay to move this to ubuntu_install_core.sh

@ashutosh-arm
Copy link
Contributor

Submitting this now. We can take up other changes in a follow up if needed.

Copy link
Contributor

@ashutosh-arm ashutosh-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lhutton1 😄

@ashutosh-arm ashutosh-arm merged commit c9ab197 into apache:main Mar 14, 2023
@lhutton1 lhutton1 deleted the npu-openssh branch April 6, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants