Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLVM][BugFix] Fix include Triplet.h bug when LLVM version>= 17 #14235

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

FrankYzy
Copy link
Contributor

@FrankYzy FrankYzy commented Mar 8, 2023

In the latest version of llvm-project, the llvm/ADT/Triple.h has been moved to llvm/TargetParser/Triple.h. Thus, anyone who compile and install llvm from source may encounter this:

fatal error: llvm/ADT/Triple.h: No such file or directory
   30 | #include <llvm/ADT/Triple.h>

This error can be solved by adding LLVM_VERSION_MAJOR judgement to include correct head file.

#14136

@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 8, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: llvm, bugfix See #10317 for details

Generated by tvm-bot

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the patch!

@masahi masahi merged commit 75f8307 into apache:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants