Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIR] Enhance loop unroll with unroll local access #14224

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Mar 7, 2023

This PR enhances the unroller with an unroll local access option. This option will detect loop variables that access local memories and unroll them independent of other options.

A test case is added. This option is by default turned off and can be useful in certain cases to improve unroller as these local memory access have to be unrolled at some time pt to be lifted as registers.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 7, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@tqchen tqchen changed the title [TIR] Enhance loop unroll with unroll local access. [TIR] Enhance loop unroll with unroll local access Mar 7, 2023
src/tir/transforms/unroll_loop.cc Outdated Show resolved Hide resolved
src/tir/transforms/unroll_loop.cc Outdated Show resolved Hide resolved
This PR enhances the unroller with an unroll local access option.
This option will detect loop variables that access local memories
and unroll them independent of other options.

A test case is added. This option is by default turned off and
can be useful in certain cases to improve unroller as these
local memory access have to be unrolled at some time pt to be
lifted as registers
Copy link
Member

@yzh119 yzh119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junrushao junrushao merged commit 56ddd37 into apache:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants