Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microTVM][Zephyr] Remove unnecessary use of generate_c_interface_header #14091

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

mehrdadh
Copy link
Member

In standalone mode we can use the generated tvmgen_default.h in model/host/include instead of regenerating it using generate_c_interface_header.
This PR also moves test_qemu_make_fail to test_zephyr since this test is not a standalone mode test.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 22, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@mehrdadh mehrdadh requested a review from Mousius February 22, 2023 21:22
Copy link
Member

@guberti guberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mehrdadh mehrdadh merged commit e0a825d into apache:main Feb 23, 2023
@mehrdadh mehrdadh deleted the micro/refactor_generate_interface_c branch February 23, 2023 19:12
yongwww pushed a commit to yongwww/tvm that referenced this pull request Feb 27, 2023
…der (apache#14091)

In standalone mode we can use the generated tvmgen_default.h in model/host/include instead of regenerating it using generate_c_interface_header.
This PR also moves test_qemu_make_fail to test_zephyr since this test is not a standalone mode test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants