Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arith][UnitTest] Parametrize tests of RewriteSimplifier #13923

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

Lunderberg
Copy link
Contributor

Split out each of the simplification test cases for RewriteSimplifier into independent parametrized unit tests.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 6, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@Lunderberg
Copy link
Contributor Author

This arose from some experiments regarding RewriteSimplifier that didn't end up materializing. During development, it had become difficult to see the effect of changes, because a failure in simplifying one expression preventing any further expressions from being tested in that unit test.

@Lunderberg Lunderberg force-pushed the parametrize_rewrite_simplify branch from eaf2a37 to 554359c Compare February 7, 2023 14:26
@masahi masahi merged commit c36ae1c into apache:main Feb 8, 2023
@Lunderberg Lunderberg deleted the parametrize_rewrite_simplify branch February 8, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants