-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docker][microTVM]Fix Zephyr 0.15.2 SDK installation and separate Zephyr python environment #13829
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
6c6be5f
to
e363f1e
Compare
e363f1e
to
f1afce4
Compare
f1afce4
to
e5548cd
Compare
RUN bash /install/ubuntu_install_zephyr.sh | ||
ENV ZEPHYR_BASE=/opt/zephyrproject/zephyr | ||
|
||
#Zephyr SDK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#Zephyr SDK | |
# Zephyr SDK |
|
||
# the requirements above overwrite junintparser with an older version, but it is not | ||
# used so overwrite it again with the correct version | ||
pip3 install junitparser==2.4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this just using the system Python with python_cmd
here? This should still re-install junitparser since that was a hack to get a specific version working in CI which didn't agree with zephyr's requirements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i might have removed pip3 to stop ppl from installing stuff outside the tvm venv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but will allow @driazati to approve
|
||
# the requirements above overwrite junintparser with an older version, but it is not | ||
# used so overwrite it again with the correct version | ||
pip3 install junitparser==2.4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i might have removed pip3 to stop ppl from installing stuff outside the tvm venv
…hyr python environment (apache#13829) This PR fixes the SDK installation and separates SDK installation from ZephyrProject installation. Also it separates the Zephyr python environment to 3.8 which is the required version and it is different than tvm virtual env.
This PR fixes the SDK installation and separates SDK installation from ZephyrProject installation.
Also it separates the Zephyr python environment to 3.8 which is the required version and it is different than tvm virtual env.