Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HotFix][docs] Use correct Colab button URL #13725

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

guberti
Copy link
Member

@guberti guberti commented Jan 8, 2023

PR #13627 added Google Colab support to the TVM tutorials, allowing them to be opened interactively with one click. This mostly works - try it yourself!

However, the button to open the tutorial in Google Colab does not render, as #13627 used the wrong URL:

image

The file is stored in the repo tlc-pack/web-data, not apache/web-data. This PR fixes the bug and makes the button render correctly.

cc @mehrdadh

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 8, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@github-actions github-actions bot requested a review from mehrdadh January 8, 2023 07:51
@guberti
Copy link
Member Author

guberti commented Jan 8, 2023

Before merging this, we need to confirm this change will trigger the docs to be re-built and re-deployed. I believe that happens after every PR - if this is not the case, let me know.

Copy link
Member

@driazati driazati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it works on https://pr-docs.tlcpack.ai/PR-13725/1/docs/tutorial/install.html#sphx-glr-tutorial-install-py, the deploy should happen automatically once this is merged

@guberti guberti merged commit 5db453e into apache:main Jan 9, 2023
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
* [docs] Use correct Colab button URL

* Black format conf.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants