Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microTVM] Fix MacOS build with USE_MICRO=ON #13711

Merged
merged 1 commit into from
Jan 6, 2023
Merged

[microTVM] Fix MacOS build with USE_MICRO=ON #13711

merged 1 commit into from
Jan 6, 2023

Conversation

alanmacd
Copy link
Contributor

@alanmacd alanmacd commented Jan 6, 2023

This fixes an issue when building on MacOS with USE_MICRO=ON caused by changes made in #13600

The CMake generator expression for the Clang conditional was looking for a target property that no longer exists.

Fixes #13709

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 6, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@alanmacd alanmacd changed the title Fix MacOS build with USE_MICRO=ON [microTVM] Fix MacOS build with USE_MICRO=ON Jan 6, 2023
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @alanmacd !

@masahi masahi merged commit 21d7968 into apache:main Jan 6, 2023
@alanmacd alanmacd deleted the fix-mac-os-use-micro branch January 26, 2023 23:57
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] USE_MICRO=ON doesn't build anymore
4 participants