Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetaSchedule] Add pass instrument to MetaSchedule api #13688

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

tkonolige
Copy link
Contributor

Add the instrument parameter from the PassContext api to the meta schedule tuning api.

@masahi @junrushao

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 3, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@masahi
Copy link
Member

masahi commented Jan 3, 2023

What's the use case of this param during tuning?

@tkonolige
Copy link
Contributor Author

A couple use cases:

  • Profiling time spent in each pass during task extraction
  • Enabling or disabling passes based on a certain context (a feature of the pass instrument api)

@masahi
Copy link
Member

masahi commented Jan 3, 2023

Is this needed only if #13470 doesn't get in?

@tkonolige
Copy link
Contributor Author

Yes that is correct.

Add the `instrument` parameter from the `PassContext` api to the meta
schedule tuning api.
@tkonolige tkonolige force-pushed the add_pass_instrument_ms branch from 0306c95 to 5b78e6b Compare January 11, 2023 17:58
@tkonolige
Copy link
Contributor Author

@masahi How about we merge this as #13470 is still in discussion?

@masahi
Copy link
Member

masahi commented Jan 11, 2023

Hopefully we overhaul the current API to clean up mostly unused parameters.

@masahi masahi merged commit f71841a into apache:main Jan 11, 2023
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
* [MetaSchedule] Add pass instrument to MetaSchedule api

Add the `instrument` parameter from the `PassContext` api to the meta
schedule tuning api.

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants