-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[microTVM][Zephyr] Fix TVMC test on hardware #13598
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
@tvm-bot rerun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Folks, please, the PR description has to be more descriptive. This will help others outside the project, which are not sitting close at the same working table, or attending the same weekly company meeting, to understand and follow how the project evolves or changes over time. It's not just a matter of fixing stuff, but also about sharing information and progress.
Is that hardware a Zephyr HW, an Arduino HW or both? Which board exactly the test is failing and how? I (others) might encounter a similar error on a different board that requires more stack to run the tests in the future and I (and probably others not working close to us) would like to do the due git archaeology to find out hints about how to fix the error! I know it's very simple change but yet there is a lot to be said and shared about it, so, please, add the details to the PR description and, specially, take care to land it neatly with the commit message (also as per the Commit Message Guideline. And please, don't forget the a space between the tags and the title!
--
Alright with adding a default main stack size to run tests on Zephyr, but won't Arduino fail on that since config_main_stack_size
is not available on Arduino platform? Hence should a conditional be added in the test to not pass such a option when the Arduino platform is selected?
Cheers.
@gromero sorry about the PR description. I will add more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mehrdadh Thanks, LGTM!
I think CI error is not related to the change, so maybe just re-trigger.
@tvm-bot rerun |
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/3689290247
|
0ba6d2c
to
940909e
Compare
Hi all. I think it's important to echo @gromero's comment regarding the Commit Message Guideline. For next PRs, at merging time, please take a moment to adjust the commit message to be more self-explanatory and leave a good track of the changes in our git history. As I'm involved in the ongoing release process, it complicates a lot the process to be able to track changes that have generic names or no commit message body. |
* fixed test * fix flag for arduino
* fixed test * fix flag for arduino
This PR adds stack size to run test on hardware for Zephyr. It is not added for Arduino since it is not required.
4096 is derived from experiment on nucleo_l4r5zi.