[TOPI] Bitserial low-precision convolution #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
June 5, 2018 16:37
…ing and accessing vectors
cowanmeg
changed the title
|
please remove change in the submodule and update to the lastest one |
tqchen
requested changes
Jun 25, 2018
topi/python/topi/generic/nn.py
Outdated
| @@ -53,6 +53,22 @@ def schedule_conv2d_nhwc(outs): | |||
| """ | |||
| return _default_schedule(outs, False) | |||
|
|
|||
| @tvm.target.generic_func | |||
| def schedule_qdense(outs): | |||
| def _intrin_func(ins, outs): | ||
| ww, xx = ins | ||
| zz = outs[0] | ||
| vpadd_id = tvm.const(647, 'uint32') |
There was a problem hiding this comment.
Did we develop an intrinsic id query function by name? since this may differ in llvm version
|
Some actionable items to improve the intrinsic id finding
|
tqchen
requested changes
Jun 26, 2018
topi/python/topi/generic/nn.py
Outdated
|
|
||
| @tvm.target.generic_func | ||
| def schedule_bitserial_conv2d_nhwc(outs): | ||
| """Schedule for qconv2d_nhwc |
There was a problem hiding this comment.
qconv2d -> bitserial, maybe try to do a search for qconv2d and rename
tqchen
requested changes
Jun 26, 2018
| func(a, w, b) | ||
| np.testing.assert_allclose(b.asnumpy(), b_np, rtol=1e-5) | ||
|
|
||
| def test_bitserial_conv2d(): |
There was a problem hiding this comment.
Since there is a specialization path for ARM, let us add a testcase up to codegen(but not actually run the code) and quickly checking we have the intrinsic we need
tqchen
requested changes
Jul 16, 2018
topi/python/topi/generic/nn.py
Outdated
| @@ -53,6 +53,22 @@ def schedule_conv2d_nhwc(outs): | |||
| """ | |||
| return _default_schedule(outs, False) | |||
|
|
|||
| @tvm.target.generic_func | |||
| def schedule_qdense(outs): | |||
topi/python/topi/generic/nn.py
Outdated
| @@ -143,6 +159,41 @@ def schedule_depthwise_conv2d_nhwc(outs): | |||
| """ | |||
| return _default_schedule(outs, False) | |||
|
|
|||
| @tvm.target.generic_func | |||
| def schedule_bitserial_conv2d_nchw(outs): | |||
| """Schedule for qconv2d_nchw | |||
There was a problem hiding this comment.
qconv2d->bitserial_conv2d, do a search over qconv2d and replace by bitserial_conv2d
tqchen
added
status: review in progress
status: need update
|
please followup with the naming change and llvm intrinsic id query function |
tqchen
approved these changes
Jul 23, 2018
|
Thanks @cowanmeg for improving the PR! this is now merged |
tqchen
removed
status: need update
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Aug 4, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitserial low-precision convolution operators for x86 and raspberry pi
Raspberry pi schedules include optimized microkernel