Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIR] Expose Stack-related TVM builtins in Python #12429

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

cyx-6
Copy link
Contributor

@cyx-6 cyx-6 commented Aug 15, 2022

op list:
tvm_stack_alloca
tvm_stack_make_shape
tvm_stack_make_array

Used and tested for future TVMScript parser

Co-Authored-By: yongwww <[email protected]>

cc @junrushao1994

@cyx-6 cyx-6 changed the title [TIR] Expose TIR arithmetic ops to python [TIR] Expose TVM-builtins and runtime ops to python Aug 15, 2022
@github-actions github-actions bot requested a review from junrushao August 15, 2022 01:36
@junrushao junrushao changed the title [TIR] Expose TVM-builtins and runtime ops to python [TIR] Expose Stack-related TVM builtins in Python Aug 15, 2022
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Those few operations are TVM builtin and have been widely tested in unittests, so I'm not going to ask for extra tests

@junrushao junrushao merged commit bb51386 into apache:main Aug 15, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
Added the following operations in TIR:
- `tvm_stack_alloca`
- `tvm_stack_make_shape`
- `tvm_stack_make_array`

Co-Authored-By: yongwww <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants