Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] default use spawn for fork safety #1240

Merged
merged 4 commits into from
Jun 7, 2018
Merged

[RPC] default use spawn for fork safety #1240

merged 4 commits into from
Jun 7, 2018

Conversation

Laurawly
Copy link
Contributor

@Laurawly Laurawly commented Jun 6, 2018

No description provided.

@tqchen
Copy link
Member

tqchen commented Jun 6, 2018

Refer to https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods, spawn starts a fresh process and can be slower than fork.

Let us add an option to args to rpc_server, --no-fork to force use of spawn and document the possible problems related to fork. The default behavior works fine for many cases already.

@Laurawly
Copy link
Contributor Author

Laurawly commented Jun 6, 2018

Although it will be slower, spawn will greatly avoid massive potential "compiler internal error" caused by forking.

@tqchen tqchen merged commit 3f674b3 into apache:master Jun 7, 2018
nishi-t pushed a commit to nishi-t/tvm that referenced this pull request Jun 7, 2018
tqchen pushed a commit to tqchen/tvm that referenced this pull request Jul 6, 2018
mnuyens pushed a commit to mnuyens/tvm that referenced this pull request Jul 10, 2018
sergei-mironov pushed a commit to sergei-mironov/tvm that referenced this pull request Aug 8, 2018
@Laurawly Laurawly deleted the rpc branch March 22, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants