Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Target] Replace IsaAnalyzer with Target Features #12322

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

Mousius
Copy link
Member

@Mousius Mousius commented Aug 5, 2022

This is clean up to use the new target.features instead of IsaAnalyzer.

@Mousius Mousius force-pushed the target-parser-isa-analyzer branch 2 times, most recently from e24295f to 3e5f99d Compare August 7, 2022 20:44
@Mousius Mousius force-pushed the target-parser-isa-analyzer branch from 3e5f99d to 6efdccd Compare August 15, 2022 10:36
@Mousius Mousius marked this pull request as ready for review August 15, 2022 10:49
@github-actions
Copy link
Contributor

It has been a while since this PR was updated, please leave a review or address the outstanding comments. @Mousius if this PR is still a work in progress, please convert it to a draft until it is ready for review.

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but did you mean to commit python/MANIFEST.in?

This is clean up to use the new `target.features` instead of `IsaAnalyzer`.
@Mousius Mousius force-pushed the target-parser-isa-analyzer branch from 6efdccd to 054a503 Compare August 23, 2022 12:59
@Mousius
Copy link
Member Author

Mousius commented Aug 23, 2022

Looks good, but did you mean to commit python/MANIFEST.in?

What do you mean? 🙈

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mousius, LGTM!

@lhutton1 lhutton1 merged commit 592148a into apache:main Aug 24, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
This is clean up to use the new `target.features` instead of `IsaAnalyzer`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants