Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMSIS-NN] Re-use CPU Target Parser #12320

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

Mousius
Copy link
Member

@Mousius Mousius commented Aug 5, 2022

Previously CMSISNNFlags was derived using logic specific to the external code generator, this converts the external code generator options into a Target.

cc @areusch

@Mousius Mousius force-pushed the target-parser-cmsis-nn branch from c474c30 to bfed2a9 Compare August 7, 2022 20:43
Previously `CMSISNNFlags` was derived using logic specific to the external code generator, this converts the external code generator options into a `Target`.
@Mousius Mousius force-pushed the target-parser-cmsis-nn branch from bfed2a9 to 3d4c059 Compare August 15, 2022 10:35
@Mousius Mousius marked this pull request as ready for review August 15, 2022 10:49
@github-actions github-actions bot requested a review from areusch August 16, 2022 09:39
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat :) thanks @Mousius !

@@ -31,10 +34,11 @@ tvm::transform::Pass RelayToTIR();
runtime::Module TIRToRuntime(IRModule mod, Target target);

TVM_REGISTER_TARGET_KIND("cmsis-nn", kDLCPU)
.add_attr_option<Array<String>>("mattr")
.add_attr_option<String>("mcpu")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just musing, i'm sensing we'll shortly want a way to express this as "whatever target_host did"

@areusch areusch merged commit d1e6f39 into apache:main Aug 18, 2022
@Mousius Mousius deleted the target-parser-cmsis-nn branch August 19, 2022 10:18
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
Previously `CMSISNNFlags` was derived using logic specific to the external code generator, this converts the external code generator options into a `Target`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants