-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix some errors in unittests #12170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
placeholder_165 = T.match_buffer(placeholder_162, [100352], dtype="int16", elem_offset=0, align=128, offset_factor=1) | ||
placeholder_166 = T.match_buffer(placeholder_163, [4608], dtype="int16", elem_offset=0, align=128, offset_factor=1) | ||
placeholder_167 = T.match_buffer(placeholder_164, [512], dtype="int32", elem_offset=0, align=128, offset_factor=1) | ||
T_cast_77 = T.match_buffer(T_cast_76, [100352], dtype="int16", elem_offset=0, align=128, offset_factor=1) | ||
sid_21 = T.allocate_const([0,1,2,3,4,5,6,7], "int8", [8]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the order matters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
T.allocate_const
will create a concise scoping here. Then the following T.match_buffer
's are within the scope of T.allocate_const
, which is not right before first block
?
In fact, if you print that script, the T.allocate_const
will be printed after all T.match_buffer
, as the changes in this pr.
* unittests fix 0 * fix unittests * fix unittests * fix unittest * fix unittest * fix unittest * Revert "fix unittest" This reverts commit 09b6b41. * fix unittests * fix
* unittests fix 0 * fix unittests * fix unittests * fix unittest * fix unittest * fix unittest * Revert "fix unittest" This reverts commit 09b6b41. * fix unittests * fix
The errors are mainly inconsistent
kwargs
, typos, wrong order ofstmt
and redundant annotations.