Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix some errors in unittests #12170

Merged
merged 9 commits into from
Jul 26, 2022
Merged

Conversation

cyx-6
Copy link
Contributor

@cyx-6 cyx-6 commented Jul 25, 2022

The errors are mainly inconsistent kwargs, typos, wrong order of stmt and redundant annotations.

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

placeholder_165 = T.match_buffer(placeholder_162, [100352], dtype="int16", elem_offset=0, align=128, offset_factor=1)
placeholder_166 = T.match_buffer(placeholder_163, [4608], dtype="int16", elem_offset=0, align=128, offset_factor=1)
placeholder_167 = T.match_buffer(placeholder_164, [512], dtype="int32", elem_offset=0, align=128, offset_factor=1)
T_cast_77 = T.match_buffer(T_cast_76, [100352], dtype="int16", elem_offset=0, align=128, offset_factor=1)
sid_21 = T.allocate_const([0,1,2,3,4,5,6,7], "int8", [8])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the order matters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T.allocate_const will create a concise scoping here. Then the following T.match_buffer's are within the scope of T.allocate_const, which is not right before first block?
In fact, if you print that script, the T.allocate_const will be printed after all T.match_buffer, as the changes in this pr.

@Hzfengsy Hzfengsy merged commit eada707 into apache:main Jul 26, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
* unittests fix 0

* fix unittests

* fix unittests

* fix unittest

* fix unittest

* fix unittest

* Revert "fix unittest"

This reverts commit 09b6b41.

* fix unittests

* fix
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
* unittests fix 0

* fix unittests

* fix unittests

* fix unittest

* fix unittest

* fix unittest

* Revert "fix unittest"

This reverts commit 09b6b41.

* fix unittests

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants