Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][docker] Fall back to tlcpackstaging if images don't exist #11775

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

driazati
Copy link
Member

@driazati driazati commented Jun 18, 2022

See #11768. This adds a script to check if Docker images exist in tlcpack and switch to tlcpackstaging if not (the tags must match though). There is also a feature flag for this in jenkins in the DETERMINE_DOCKER_IMAGES env variable (which must be set to yes for this change to work)

cc @Mousius @areusch

driazati added a commit to driazati/tvm that referenced this pull request Jun 22, 2022
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
@driazati driazati force-pushed the fallback branch 2 times, most recently from a9ddd9d to 73985aa Compare June 22, 2022 17:04
@driazati driazati marked this pull request as ready for review June 22, 2022 17:08
driazati added a commit to driazati/tvm that referenced this pull request Jun 22, 2022
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
driazati added a commit to driazati/tvm that referenced this pull request Jun 22, 2022
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
@driazati
Copy link
Member Author

@tvm-bot rerun

)
parser.add_argument(
"--base-dir",
default=".docker-image-names",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be relative to repo root?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in tests it needs to be off in a random tempdir (and that's the only place this is really used)

@github-actions
Copy link
Contributor

Built docs for commit 9240ff20484c07f896cb4a3d6ed0cfb9be3b5a79 can be found here.

@driazati driazati merged commit 6660e27 into apache:main Jun 23, 2022
driazati added a commit to driazati/tvm that referenced this pull request Jun 23, 2022
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
driazati added a commit to driazati/tvm that referenced this pull request Jun 30, 2022
This uses apache#11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack
driazati added a commit to driazati/tvm that referenced this pull request Jun 30, 2022
This uses apache#11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack
driazati added a commit to driazati/tvm that referenced this pull request Jul 1, 2022
This uses apache#11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack
driazati added a commit to driazati/tvm that referenced this pull request Jul 1, 2022
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
leandron pushed a commit that referenced this pull request Jul 1, 2022
This uses #11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack

Co-authored-by: driazati <[email protected]>
blackkker pushed a commit to blackkker/tvm that referenced this pull request Jul 7, 2022
…e#11775)

See apache#11768. This adds a script to check if Docker images exist in `tlcpack` and switch to `tlcpackstaging` if not (the tags must match though). There is also a feature flag for this in jenkins in the `DETERMINE_DOCKER_IMAGES` env variable (which must be set to `yes` for this change to work)
blackkker pushed a commit to blackkker/tvm that referenced this pull request Jul 7, 2022
This uses apache#11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack

Co-authored-by: driazati <[email protected]>
driazati added a commit to driazati/tvm that referenced this pull request Jul 11, 2022
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
masahi pushed a commit to masahi/tvm that referenced this pull request Jul 15, 2022
This uses apache#11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack

Co-authored-by: driazati <[email protected]>
driazati added a commit to driazati/tvm that referenced this pull request Jul 28, 2022
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
driazati added a commit to driazati/tvm that referenced this pull request Jul 28, 2022
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
driazati added a commit to driazati/tvm that referenced this pull request Aug 2, 2022
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
driazati added a commit to driazati/tvm that referenced this pull request Aug 11, 2022
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
driazati added a commit to driazati/tvm that referenced this pull request Aug 11, 2022
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
driazati added a commit that referenced this pull request Aug 11, 2022
See #11768, this PR changes the deploy workflow so that after a successful build with fallback images (see #11775), they get moved over to tlcpack automatically. Since the images are moving repositories we can't just rename the blobs in docker, so there needs to be a full `pull -> tag -> push` for each image
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically. Since the images are moving repositories we can't just rename the blobs in docker, so there needs to be a full `pull -> tag -> push` for each image
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
This uses apache#11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack

Co-authored-by: driazati <[email protected]>
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically. Since the images are moving repositories we can't just rename the blobs in docker, so there needs to be a full `pull -> tag -> push` for each image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants