-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][docker] Fall back to tlcpackstaging if images don't exist #11775
Conversation
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
a9ddd9d
to
73985aa
Compare
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
@tvm-bot rerun |
) | ||
parser.add_argument( | ||
"--base-dir", | ||
default=".docker-image-names", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be relative to repo root?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in tests it needs to be off in a random tempdir (and that's the only place this is really used)
Built docs for commit 9240ff20484c07f896cb4a3d6ed0cfb9be3b5a79 can be found here. |
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
This uses apache#11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack
This uses apache#11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack
This uses apache#11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
This uses #11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack Co-authored-by: driazati <[email protected]>
…e#11775) See apache#11768. This adds a script to check if Docker images exist in `tlcpack` and switch to `tlcpackstaging` if not (the tags must match though). There is also a feature flag for this in jenkins in the `DETERMINE_DOCKER_IMAGES` env variable (which must be set to `yes` for this change to work)
This uses apache#11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack Co-authored-by: driazati <[email protected]>
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
This uses apache#11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack Co-authored-by: driazati <[email protected]>
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically
See #11768, this PR changes the deploy workflow so that after a successful build with fallback images (see #11775), they get moved over to tlcpack automatically. Since the images are moving repositories we can't just rename the blobs in docker, so there needs to be a full `pull -> tag -> push` for each image
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically. Since the images are moving repositories we can't just rename the blobs in docker, so there needs to be a full `pull -> tag -> push` for each image
This uses apache#11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack Co-authored-by: driazati <[email protected]>
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically. Since the images are moving repositories we can't just rename the blobs in docker, so there needs to be a full `pull -> tag -> push` for each image
See #11768. This adds a script to check if Docker images exist in
tlcpack
and switch totlcpackstaging
if not (the tags must match though). There is also a feature flag for this in jenkins in theDETERMINE_DOCKER_IMAGES
env variable (which must be set toyes
for this change to work)cc @Mousius @areusch