-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[microNPU] Reorder copies and computes based on the cycle count #11591
Merged
Mousius
merged 3 commits into
apache:main
from
ekalda:copy-compute-reorder-compute-cycles
Aug 12, 2022
Merged
[microNPU] Reorder copies and computes based on the cycle count #11591
Mousius
merged 3 commits into
apache:main
from
ekalda:copy-compute-reorder-compute-cycles
Aug 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhutton1
reviewed
Jun 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ekalda, looks good! I just had a couple of questions/comments
tests/python/contrib/test_ethosu/test_copy_compute_reordering.py
Outdated
Show resolved
Hide resolved
ekalda
force-pushed
the
copy-compute-reorder-compute-cycles
branch
from
July 14, 2022 12:49
6db2133
to
55816cc
Compare
lhutton1
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will leave for others to take a look as well
If the cascader is enabled and the ops in TIR have the cycle count annotation, enabling the reorder_by_cycles option will reorder to copies and computes based on a cycle count. If reorder_by_cycles is enabled, max_copy_movements is ignored. This pass is currently not part of the TIR pipeline since it assumes that weights and bias of a compute op are merged into one constant (which is WIP).
ekalda
force-pushed
the
copy-compute-reorder-compute-cycles
branch
from
August 12, 2022 12:42
55816cc
to
dd29f9f
Compare
Mousius
approved these changes
Aug 12, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…he#11591) If the cascader is enabled and the ops in TIR have the cycle count annotation, enabling the reorder_by_cycles option will reorder to copies and computes based on a cycle count. If reorder_by_cycles is enabled, max_copy_movements is ignored. This pass is currently not part of the TIR pipeline since it assumes that weights and bias of a compute op are merged into one constant (which is WIP).
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
…he#11591) If the cascader is enabled and the ops in TIR have the cycle count annotation, enabling the reorder_by_cycles option will reorder to copies and computes based on a cycle count. If reorder_by_cycles is enabled, max_copy_movements is ignored. This pass is currently not part of the TIR pipeline since it assumes that weights and bias of a compute op are merged into one constant (which is WIP).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the cascader is enabled and the ops in TIR have the cycle
count annotation, enabling the reorder_by_cycles option will
reorder to copies and computes based on a cycle count.
If reorder_by_cycles is enabled, max_copy_movements is ignored.
This pass is currently not part of the TIR pipeline since it
assumes that weights and bias of a compute op are merged into
one constant (which is WIP).
cc @Mousius @lhutton1