-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MetaSchedule] Enable Task Filtering #11512
[MetaSchedule] Enable Task Filtering #11512
Conversation
Can we add testcases? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Echo @Hzfengsy's comment that we may need a test case.
@Hzfengsy thanks for asking! It's pretty hard to add a unittest given we will need an actual end-to-end network that takes hours to run...In this particular case, it might be good to leave it to future integration test instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, unit tests for task extraction don't need to run tune. Instead, it only needs to extract tasks and verify their number and workloads. However, if MetaSchedule doesn't have unit tests for task extractions yet, we could of course add it later.
I'm happy to add a simple unittest without tuning :-) |
16a8851
to
5f96e8a
Compare
This PR allows
relay.backend.MetaScheduleExtractTask
to take an extra argumentfilter_func
which filters out tasks that don't need tuning. The counterpart of AutoScheduler istraverse_to_get_io_tensors
.