Add utility that asserts that input IRModule is not mutated in a pass. #11498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigiblender
force-pushed
the
utility-ir-module
branch
from
98f0160 to
98cc824
Compare
gigiblender
force-pushed
the
utility-ir-module
branch
from
98cc824 to
e35a103
Compare
masahi
approved these changes
May 30, 2022
areusch
reviewed
May 31, 2022
There was a problem hiding this comment.
@gigiblender just wanted to point out one thing on this PR, otherwise I think it looks good.
| pass_ctx.InstrumentAfterPass(ret, pass_info); | ||
| return std::move(ret); | ||
| } | ||
|
|
||
| IRModule Pass::AssertImmutableModule(const IRModule& mod, const PassNode* node, |
There was a problem hiding this comment.
suggest not taking const IRModule&--instead take IRModule. right now this is basically re-implemeting the copy constructor rather than just using it
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a utility for testing purposes that asserts an IRModule used as input to a pass is not modified in place.
The
testing.immutable_moduleoption can be set to true in aPassContextto enable the assertion.