[CI] Refactor of tvm.testing.requires_* annotations #11313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mehrdadh I expect this to conflict with these changes in PR#11294. Between the two, your PR takes priority, as it is solving an immediate issue. If all goes well, I don't expect the conflict to be difficult to resolve, as the corresponding change after this refactor would be to replace |
Previously, the same message was given regardless of why a test couldn't be run. This has been split up into separate checks for TVM cmake options in `config.cmake`, enabled targets in `TVM_TEST_TARGETS` environment variable, and checks for available hardware.
Lunderberg
force-pushed
the
requires_feature_refactor
branch
from
4a5087f to
7bd8211
Compare
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Jun 7, 2022
These were enabled in apache#11294, then erroneously disabled in apache#11313. This applies the same fix as in apache#11294, checking the `ANDROID_SERIAL_NUMBER` to determine if Hexagon tests can execute at runtime, but using the refactored `pytest.skipif` messages introduced in apache#11313.
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Jun 7, 2022
These were enabled in apache#11294, then erroneously disabled in apache#11313. This applies the same fix as in apache#11294, checking the `ANDROID_SERIAL_NUMBER` to determine if Hexagon tests can execute at runtime, but using the refactored `pytest.skipif` messages introduced in apache#11313.
kparzysz-quic
pushed a commit
that referenced
this pull request
Jun 7, 2022
* [Hexagon][CI] Re-enable Hexagon tests in CI These were enabled in #11294, then erroneously disabled in #11313. This applies the same fix as in #11294, checking the `ANDROID_SERIAL_NUMBER` to determine if Hexagon tests can execute at runtime, but using the refactored `pytest.skipif` messages introduced in #11313. * Fixed circular dependency, but feels somewhat ugly
Kathryn-cat
pushed a commit
to Kathryn-cat/tvm
that referenced
this pull request
Jun 10, 2022
* [Hexagon][CI] Re-enable Hexagon tests in CI These were enabled in apache#11294, then erroneously disabled in apache#11313. This applies the same fix as in apache#11294, checking the `ANDROID_SERIAL_NUMBER` to determine if Hexagon tests can execute at runtime, but using the refactored `pytest.skipif` messages introduced in apache#11313. * Fixed circular dependency, but feels somewhat ugly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two main goals.
config.cmake, disabled inTVM_TEST_TARGETS, or no device available).@tvm.testing.requires_*decorators maintain the same semantics, skipping a test unless both compile-time and run-time support are present. This adds an optional argument to indicate that the test does not require a physical device (e.g. to require cuda library support without requiring a cuda-capable GPU:@requires_cuda(support_required="compile-only")cc @Mousius @areusch @driazati