Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Meta Schedule] Fix testing issues for models with more than one inputs #11298

Merged
merged 12 commits into from
May 27, 2022
Merged

[Meta Schedule] Fix testing issues for models with more than one inputs #11298

merged 12 commits into from
May 27, 2022

Conversation

shingjan
Copy link

@shingjan shingjan commented May 12, 2022 •
edited
Loading

This PR intends to fix the issues in tune_relay_meta_schedule.py and tune_relay_auto_schedule.py for handling models with more than one input, like bert.

cc @zxybazh @junrushao1994 @AndrewZhaoLuo

@github-actions github-actions bot requested review from junrushao and zxybazh May 12, 2022 21:58
@shingjan shingjan force-pushed the fix_test_tune_script branch from 6bf8b60 to 14edabd Compare May 13, 2022 23:26
@github-actions github-actions bot requested a review from AndrewZhaoLuo May 13, 2022 23:31
zxybazh
zxybazh requested changes May 17, 2022
View reviewed changes
Copy link
Member

@zxybazh zxybazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending in the patch. I think there is not need to preserve the order of inputs, we can directly use a dictionary here with input name as key and input value as value.

python/tvm/meta_schedule/testing/tune_relay_meta_schedule.py Outdated Show resolved Hide resolved
python/tvm/meta_schedule/testing/tune_relay_auto_scheduler.py Outdated Show resolved Hide resolved
python/tvm/meta_schedule/testing/tune_relay_meta_schedule.py Show resolved Hide resolved
python/tvm/meta_schedule/testing/tune_relay_auto_scheduler.py Outdated Show resolved Hide resolved
@shingjan shingjan force-pushed the fix_test_tune_script branch from 01a582d to 7099d81 Compare May 18, 2022 00:05
@shingjan shingjan requested a review from zxybazh May 18, 2022 00:05
@shingjan
Copy link
Author

@zxybazh comments addressed and rebased. Should be good for another look. Thanks!

junrushao
junrushao approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have other comments. Please fix the CI and will let @zxybazh decide

@shingjan shingjan force-pushed the fix_test_tune_script branch 2 times, most recently from 11669ea to 7dffe8a Compare May 27, 2022 00:19
@shingjan shingjan force-pushed the fix_test_tune_script branch from 313eccf to 7922bcc Compare May 27, 2022 18:32
zxybazh
zxybazh approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@zxybazh zxybazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the effort!

@zxybazh zxybazh merged commit 80d9549 into apache:main May 27, 2022
@YuchenJin YuchenJin mentioned this pull request Jun 21, 2022
Merged
@shingjan shingjan deleted the fix_test_tune_script branch July 5, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrushao junrushao junrushao approved these changes

@zxybazh zxybazh zxybazh approved these changes

@AndrewZhaoLuo AndrewZhaoLuo Awaiting requested review from AndrewZhaoLuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shingjan @zxybazh @junrushao