Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIR] Bind iter domain in analyzer in CreatePrimFunc #11187

Merged
merged 3 commits into from
Apr 30, 2022
Merged

[TIR] Bind iter domain in analyzer in CreatePrimFunc #11187

merged 3 commits into from
Apr 30, 2022

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Apr 29, 2022

@github-actions github-actions bot requested review from Hzfengsy and junrushao April 29, 2022 17:32
junrushao
junrushao approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! BTW, does it guarantee that the PrimFunc created is simplified?

@vinx13
Copy link
Member Author

vinx13 commented Apr 29, 2022

It makes best efforts. But generally arith analyzer doesn't guarantee the result is simplified

@junrushao
Copy link
Member

Do you think it might make sense to call the Simplify pass upon PrimFunc creation?

@vinx13
Copy link
Member Author

vinx13 commented Apr 29, 2022

We've already called analyzre->Simplify for each expression, but it might still be helpful to call the Simplify pass again

@masahi masahi merged commit 26cefab into apache:main Apr 30, 2022
@vinx13 vinx13 mentioned this pull request May 6, 2022
Merged
Hzfengsy added a commit to Hzfengsy/tvm that referenced this pull request May 11, 2022
@Hzfengsy
Revert "[TIR] Bind iter domain in analyzer in CreatePrimFunc (apache#…
2d3b324 
…11187)"

This reverts commit 26cefab.
shtinsa pushed a commit to Deelvin/tvm that referenced this pull request May 17, 2022
@vinx13
[TIR] Bind iter domain in analyzer in CreatePrimFunc (apache#11187)
30482da 
* [TIR] Bind iter domain in analyzer in CreatePrimFunc

* lint

* fix test
SebastianBoblest pushed a commit to SebastianBoblest/tvm that referenced this pull request May 27, 2022
@vinx13
[TIR] Bind iter domain in analyzer in CreatePrimFunc (apache#11187)
a11ea23 
* [TIR] Bind iter domain in analyzer in CreatePrimFunc

* lint

* fix test
jinhongyii pushed a commit to jinhongyii/tvm that referenced this pull request Jun 20, 2022
@vinx13 @jinhongyii
[TIR] Bind iter domain in analyzer in CreatePrimFunc (apache#11187)
d4b08be 
* [TIR] Bind iter domain in analyzer in CreatePrimFunc

* lint

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrushao junrushao junrushao approved these changes

@Hzfengsy Hzfengsy Awaiting requested review from Hzfengsy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinx13 @junrushao @masahi