Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TVMC] Add configuration json files to the Python package #11063

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

leandron
Copy link
Contributor

Add the configs directory to be part of the installed version of TVM in the setuptools configuration, and introduce a new function to load the configs directory from the right paths both when TVM is locally installed for development, as well as, when it is installed as a package.

This builds on top of #11012, just adding support for the files to be added in the package. More testing needs to be added (planning for that in future patches) to support some system testing of the packaged version of TVM.

cc @Mousius @gromero @areusch for reviews

@github-actions github-actions bot requested review from Mousius, areusch and gromero April 19, 2022 16:36
Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wheely think we should land this to fix the wheels.

python/tvm/driver/tvmc/config_options.py Outdated Show resolved Hide resolved
@leandron leandron force-pushed the config_json_package branch from 0a604e7 to bde1d41 Compare April 20, 2022 09:12
Add the `configs` directory to be part of the installed version of
TVM in the setuptools configuration, and introduce a new function
to load the `configs` directory from the right paths both when TVM
is locally installed for development, as well as, when it is installed
as a package.
@leandron leandron force-pushed the config_json_package branch from bde1d41 to 04ecb67 Compare April 20, 2022 10:46
Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again!

@Mousius Mousius merged commit 970f868 into apache:main Apr 20, 2022
@Mousius
Copy link
Member

Mousius commented Apr 20, 2022

Wheely appreciate the fix @leandron !

shtinsa pushed a commit to Deelvin/tvm that referenced this pull request May 17, 2022
Add the `configs` directory to be part of the installed version of
TVM in the setuptools configuration, and introduce a new function
to load the `configs` directory from the right paths both when TVM
is locally installed for development, as well as, when it is installed
as a package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants