[Hexagon][LLVM][CodeGen] Make CodeGenHexagon a subclass of CodeGenCPU #10908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I'll try it downstream, hopefully it still works. :D |
kparzysz-quic
approved these changes
Apr 6, 2022
csullivan
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
🎉 I'll let @kparzysz-quic merge after checking with downstream.
|
@supersat @kparzysz-quic @csullivan thanks! PR is merged! |
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…apache#10908) * Initial pass at making CodeGenHexagon a subclass of CodeGenCPU * More cleanup of CodeGenHexagon * Remove unused func_handle_map_ from CodeGenHexagon * Remove CreateCallExtern and CreateCallPacked from CodeGenHexagon * Code style fixes * Run clang-format-10 over codegen_hexagon.cc
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Apr 11, 2022
…apache#10908) * Initial pass at making CodeGenHexagon a subclass of CodeGenCPU * More cleanup of CodeGenHexagon * Remove unused func_handle_map_ from CodeGenHexagon * Remove CreateCallExtern and CreateCallPacked from CodeGenHexagon * Code style fixes * Run clang-format-10 over codegen_hexagon.cc
Lucien0
pushed a commit
to Lucien0/tvm
that referenced
this pull request
Apr 19, 2022
…apache#10908) * Initial pass at making CodeGenHexagon a subclass of CodeGenCPU * More cleanup of CodeGenHexagon * Remove unused func_handle_map_ from CodeGenHexagon * Remove CreateCallExtern and CreateCallPacked from CodeGenHexagon * Code style fixes * Run clang-format-10 over codegen_hexagon.cc
altanh
pushed a commit
to altanh/tvm
that referenced
this pull request
Apr 28, 2022
…apache#10908) * Initial pass at making CodeGenHexagon a subclass of CodeGenCPU * More cleanup of CodeGenHexagon * Remove unused func_handle_map_ from CodeGenHexagon * Remove CreateCallExtern and CreateCallPacked from CodeGenHexagon * Code style fixes * Run clang-format-10 over codegen_hexagon.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of duplicate code between CodeGenCPU and CodeGenHexagon, and I suspect this will increase over time. This PR removes this duplicate code and makes CodeGenHexagon a subclass of CodeGenCPU.