Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CUBLAS] Add support for nn.dense and nn.batch_matmul #10826

Merged
merged 2 commits into from
Mar 31, 2022
Merged

[CUBLAS] Add support for nn.dense and nn.batch_matmul #10826

merged 2 commits into from
Mar 31, 2022

Conversation

mbaret
Copy link
Contributor

@mbaret mbaret commented Mar 30, 2022 •
edited
Loading

Add support for nn.dense and nn.batch_matmul using cuBLAS. This commit includes a fix for cublas.batch_matmul when mixed precision is being used.

@mbaret
[CUBLAS] Add support for nn.dense and nn.batch_matmul
1f6799d 
This commit includes a fix for cublas.batch_matmul
when mixed precision is being used.
@mbaret mbaret marked this pull request as ready for review March 30, 2022 18:28
@mbaret
Copy link
Contributor Author

mbaret commented Mar 30, 2022

cc @mbs-octoml @mikepapadim

mbs-octoml
mbs-octoml approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@mbs-octoml mbs-octoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/tvm/relay/op/contrib/cublas.py Outdated Show resolved Hide resolved
@masahi masahi merged commit 5cacecc into apache:main Mar 31, 2022
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
@mbaret
[CUBLAS] Add support for nn.dense and nn.batch_matmul (apache#10826)
bb43e96 
* [CUBLAS] Add support for nn.dense and nn.batch_matmul

This commit includes a fix for cublas.batch_matmul
when mixed precision is being used.

* Specify args in dense
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Apr 11, 2022
@mbaret @mehrdadh
[CUBLAS] Add support for nn.dense and nn.batch_matmul (apache#10826)
26ac3a3 
* [CUBLAS] Add support for nn.dense and nn.batch_matmul

This commit includes a fix for cublas.batch_matmul
when mixed precision is being used.

* Specify args in dense
@driazati driazati mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbs-octoml mbs-octoml mbs-octoml approved these changes

@masahi masahi masahi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbaret @masahi @mbs-octoml