-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hexagon] Allow execution on target or simulator from HexagonLauncher #10454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kparzysz-quic
requested review from
comaniac,
junrushao,
tqchen,
jroesch,
areusch,
yzhliu,
merrymercy,
icemelon and
zhiics
as code owners
March 2, 2022 20:59
please fix the lint issues |
Setting ANDROID_SERIAL_NUMBER=simulator will execute the tests on simulator instead of a hardware device. This patch also introduces an environment variable HEXAGON_RPC_LIB_DIR to specify the location of the hexagon_api binaries. If unset, the code will look for the binaries in the same way as before this patch.
mehrdadh
reviewed
Mar 2, 2022
mehrdadh
requested changes
Mar 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plan to enable these tests to run in Hexagon CI in a follow up PR?
masahi
approved these changes
Mar 3, 2022
@mehrdadh Yes, I'd like to do that. I'm also going to be switching our downstream CI to use the |
mehrdadh
approved these changes
Mar 3, 2022
Merged
ziqiangxu8457
pushed a commit
to ziqiangxu8457/tvm
that referenced
this pull request
Mar 6, 2022
…apache#10454) Setting ANDROID_SERIAL_NUMBER=simulator will execute the tests on simulator instead of a hardware device. This patch also introduces an environment variable HEXAGON_RPC_LIB_DIR to specify the location of the hexagon_api binaries. If unset, the code will look for the binaries in the same way as before this patch.
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…apache#10454) Setting ANDROID_SERIAL_NUMBER=simulator will execute the tests on simulator instead of a hardware device. This patch also introduces an environment variable HEXAGON_RPC_LIB_DIR to specify the location of the hexagon_api binaries. If unset, the code will look for the binaries in the same way as before this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
ANDROID_SERIAL_NUMBER=simulator
will execute the tests on simulator instead of a hardware device.This patch also introduces an environment variable
HEXAGON_RPC_LIB_DIR
to specify the location of the hexagon_api binaries. If unset, the code will look for the binaries in the same way as before this patch.