[UnitTest] Disable ptx mma tests on unsupported nvcc versions. #10229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
requested review from
comaniac,
junrushao,
tqchen,
jroesch,
areusch,
yzhliu,
merrymercy,
icemelon and
zhiics
as code owners
- Modified `tvm.contrib.nvcc.get_cuda_version` to return a `(major,minor,release)` tuple rather than a float. - Implemented `tvm.testing.requries_nvcc_version` decorator to specify the minimum `(major,minor,release)` version needed to run a unit test. - Applied decorated to unit tests in `test_tir_ptx_mma.py` that fail on earlier nvcc versions.
Lunderberg
force-pushed
the
mma_skipif
branch
from
cfb1133 to
3b53d8d
Compare
|
@Lunderberg Please take a look at the CI problem. |
|
Thank you, and the lint errors should be resolved now. |
|
@Lunderberg Need more lint fix |
|
Thank you, and more lint fixes applied. It looks like the issue in my local setup is that |
Yeah that happens to me to. I always do |
Lunderberg
force-pushed
the
mma_skipif
branch
from
da7b230 to
bd4bfc8
Compare
|
Bumped the commit to restart CI. |
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…e#10229) * [UnitTest] Disable ptx mma tests on unsupported nvcc versions. - Modified `tvm.contrib.nvcc.get_cuda_version` to return a `(major,minor,release)` tuple rather than a float. - Implemented `tvm.testing.requries_nvcc_version` decorator to specify the minimum `(major,minor,release)` version needed to run a unit test. - Applied decorated to unit tests in `test_tir_ptx_mma.py` that fail on earlier nvcc versions. * Fix lint errors. * Updated a few of the cuda version checks. * More lint fixes. * Only compare major/minor in find_libdevice, not release version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified
tvm.contrib.nvcc.get_cuda_versionto return a(major,minor,release)tuple rather than a float.Implemented
tvm.testing.requries_nvcc_versiondecorator to specify the minimum(major,minor,release)version needed to run a unit test.Applied decorated to unit tests in
test_tir_ptx_mma.pythat fail on earlier nvcc versions.