Adding support for Hexagon User DMA Engine #10217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adstraw
requested review from
vinx13,
tqchen,
liangfu,
areusch,
tmoreau89,
masahi,
kazum,
ZihengJiang,
junrushao,
jroesch and
comaniac
as code owners
adstraw
force-pushed
the
hexagon-user-dma-1d-sync
branch
from
db46dcf to
5e12171
Compare
tmoreau89
reviewed
Feb 10, 2022
| #define DESC_DESCTYPE_1D 0 | ||
| #define DESC_DESCTYPE_2D 1 | ||
|
|
||
| // TODO(Straw): Definition? Not in the spec. |
There was a problem hiding this comment.
Trying to understand what this TODO means, could you elaborate?
There was a problem hiding this comment.
Good question. The fields marked with this TODO were in header files sent by Qualcomm but the fields are not described in the spec. I left myself a TODO to investigate. Also added a "thank you" to Qualcomm in the description for sending code that was leveraged here.
tmoreau89
approved these changes
Feb 10, 2022
I added a link to the test in the description. |
|
CC @masahi and @kparzysz-quic |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* initial hexagon user dma impl * Hexagon User DMA descriptor, instruction and register headers * Synchronous 1D DMA working * HexagonBuffer unit tests passing with memcpy * cleanup * comments and orgnanize code * format and lint * init function + other code review feedback * add ifdef hexagon around inline asm
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* initial hexagon user dma impl * Hexagon User DMA descriptor, instruction and register headers * Synchronous 1D DMA working * HexagonBuffer unit tests passing with memcpy * cleanup * comments and orgnanize code * format and lint * init function + other code review feedback * add ifdef hexagon around inline asm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the Hexagon User DMA engine consisting of three header files which describe the DMA engine in terms of its descriptors, instructions and registers. Also adding a flow for synchronous (blocking) 1D (vs. 2D) DMA which mimics memcpy semantics as a starting place for Hexagon User DMA engine support. This existing test covers this PR:
tvm/tests/python/contrib/test_hexagon/rpc/test_launcher.py
Line 81 in 2a1cc09
Many thanks to the folks at Qualcomm for sending over code which was leveraged for this PR.